Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort if split_out=1 in value_counts #924

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Sort if split_out=1 in value_counts #924

merged 1 commit into from
Mar 4, 2024

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Mar 2, 2024

ref #914

milesgranger
milesgranger approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but otherwise good for me!

dask_expr/_collection.py Show resolved Hide resolved
@phofl phofl merged commit 48cefe9 into dask:main Mar 4, 2024
7 checks passed
@phofl phofl deleted the value_counts_sort branch March 4, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesgranger milesgranger milesgranger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @milesgranger