-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dask logo background? #59
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gjoseph92! FWIW I don't have a strong opinion on this topic. cc'ing @jacobtomlinson @jsignell who have been working on the docs recently -- and have a better design sense than I do : )
I added the logo texture when we recently redid the theme to visually fill the empty space on larger monitors. I experimented a bunch with stretching content across wider monitors and also centrally aligning it and neither worked well. It needs something on the right to break up all that white space. Perhaps rather than removing (😢) it would make sense to drop the opacity even further? |
Thanks for the efforts here @gjoseph92. I don't have an ultrawide to test on (and honestly I assumed folks with ultrawides never full-screen things anyway). I think you're right that the max width is a little large. Your last screenshot is looking nice. Perhaps you could make the sidebar text black as the orange doesn't have enough contrast on that black background. And the nav needs centering too. But maybe you could raise a PR with those changes? (Still kinda sad to lose the texture on the right though, I quite liked it) |
@gjoseph92 do you intend on finishing this up? |
Just opening for discussion. Personally, I find the dask logo "wallpaper" on the right side of the page a little distracting, and I'd prefer a visually cleaner look with no background. Just curious if others feel the same way, or if we like having the branding.