-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023.12 support #157
2023.12 support #157
Conversation
@lucascolley @mdhaber could you expand on what backend is missing As far as I can tell, it's in numpy, torch, cupy, jax, and dask.array, so should already work. Is the issue that it's missing from array-api-strict? |
Yes, probably implemented it because it was not in array-api-strict. I don't remember whether there were any other incompatibilities. |
OK. I have 2023 strict support ready to go data-apis/array-api-strict#35 (except for some annoying CI issues). I'll get a release out so you can use it. |
Thanks! |
|
I've just released array-api-strict with 2023.12 support. For now, it must be enabled manually using the new flags features https://data-apis.org/array-api-strict/api.html#module-array_api_strict._flags but once I'm confident there are no issues with it I'll make a release making 2023.12 the default in array-api-strict. |
Merging what I have so far so I can do a release with partial support. Work on 2023.12 support will continue in another PR. |
I am implementing 2023.12 support here. Note that some things, like the changes to dlpack, will not be wrapped and will require upstream support.
Rather than focusing on one library at a time, my plan is to implement the most important functions first for each library, and potentially do a release with partial support. Once full support is implemented I will update
__array_api_version__
. So if anyone has any functions that they'd like for me to prioritize please note them here. I am going to start with the functions used by scipy at https://github.com/scipy/scipy/blob/main/scipy/_lib/_array_api.py.Here is the checklist of functions from data-apis/array-api-tests#249:
Here is the list of changes https://data-apis.org/array-api/latest/changelog.html#v2023-12
New Functions
__array_namespace_info__
(i.e., the inspection API)clip
copysign
cumulative_sum
hypot
maximum
minimum
moveaxis
repeat
searchsorted
signbit
tile
unstack
API Changes
device
keyword added toastype
(won't be wrapped)from_dlpack
requires exceptions in some cases(won't be wrapped)copy
anddevice
keywords tofrom_dlpack
sum
,prod
,trace
output dtype change (Update dtype assertions in sum-like tests for>2023.12
versions array-api-tests#234)Other Changes
tensordot
should support negative axes