Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support copy keyword in __array__ method #12

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Support copy keyword in __array__ method #12

merged 2 commits into from
Mar 5, 2024

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Mar 2, 2024

Closes gh-11

@rgommers rgommers mentioned this pull request Mar 2, 2024
Closed
@rgommers
Copy link
Member Author

rgommers commented Mar 2, 2024

The one failure is unrelated (that's the test_solve one), but it cancelled a bunch of test jobs.

@asmeurer
Copy link
Member

asmeurer commented Mar 5, 2024

Tests should be fixed by #14

@asmeurer
Copy link
Member

asmeurer commented Mar 5, 2024

Is this a change that any library that implements __array__ will have to make?

@asmeurer asmeurer enabled auto-merge March 5, 2024 22:14
@asmeurer asmeurer merged commit ab6f323 into data-apis:main Mar 5, 2024
18 checks passed
@rgommers rgommers deleted the copy-keyword branch March 6, 2024 07:05
@rgommers
Copy link
Member Author

rgommers commented Mar 6, 2024

Is this a change that any library that implements __array__ will have to make?

Yes indeed - missing copy or dtype keywords from the __array__ signature will emit a UserWarning in 2.0, and will probably be a deprecation later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAINT: copy semantics shim
2 participants
@rgommers @asmeurer