🐛 fix(user access): fix user access in some tasks (#17) #18
Conversation
niyushabaghayi
changed the title
niyushabaghayi
requested review from
mostafaghadimi,
mehranasghari and
iamdorsa
| changed_when: false | ||
| ignore_errors: yes # Use ignore_errors instead of failed_when |
There was a problem hiding this comment.
Niyusha jan, would you please what is the difference has been made by this change? This is not that obvious for me.
There was a problem hiding this comment.
If our task cannot retrieve the "alacritty_latest_deb_url" we can find it out with a more clear message than just failing a task named "Get URL pointing to the latest alacritty .deb".
By the way I think it is unnecessary to split this task into two.
| - name: Fail the task if wget fails | ||
| fail: | ||
| msg: "Failed to retrieve the latest alacritty .deb URL" | ||
| when: alacritty_latest_deb_url.rc != 0 |
There was a problem hiding this comment.
And why do we check this result and ignore_error in the previous step?
| @@ -12,16 +12,16 @@ | |||
|
|
|||
| - name: Fetch .zshrc from remote machine | |||
| fetch: | |||
| src: /root/.zshrc | |||
| src: "{{ '/home/' + user + '/.zshrc' if user != 'root' else '/root/.zshrc' }}" | |||
There was a problem hiding this comment.
can we handle it using ansible_user instead of set condition for it? How does the user is set? does it come from the ansible_user?
There was a problem hiding this comment.
Yes, variable {{ user }} comes from ansible_user which resides in /roles/shell/vars/main.yml.
Can we just use anisble_user for less complexity?
Due to the problems with other ansible users than
root, I have fixed them in the tasks which faced problems.Please check them dear guys <3
PS, Again here, another PR, another review! I've missed it :`)