Skip to content

Commit

Permalink
Add network information to listValidEnvironments (#986)
Browse files Browse the repository at this point in the history
### Feature or Bugfix
- Bugfix

### Detail
Missing API output definition to list environment networks in creation
of notebooks

### Relates
- #983 

### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)?
  - Is the input sanitized?
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization?
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: Noah Paige <[email protected]>
  • Loading branch information
dlpzx and noah-paige authored Jan 19, 2024
1 parent ea153d5 commit 4732e4e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
5 changes: 5 additions & 0 deletions backend/dataall/core/environment/api/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@
type=gql.Ref('Organization'),
resolver=get_parent_organization,
),
gql.Field(
name='networks',
type=gql.ArrayType(gql.Ref('Vpc')),
resolver=resolve_vpc_list,
)
],
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ export const listValidEnvironments = ({ filter }) => ({
name
label
}
networks {
VpcId
privateSubnetIds
publicSubnetIds
}
}
}
}
Expand Down

0 comments on commit 4732e4e

Please sign in to comment.