Skip to content

Commit

Permalink
Tests/extend token validity (#1669)
Browse files Browse the repository at this point in the history
### Feature or Bugfix
<!-- please choose -->
- Tests


### Detail
- Extend Token Validity if integration tests enabled to account for
tests runtime
- Add Env Variable change to cognito URLs Custom Resource to force
re-run and setting callback URLs
- @petrkalos - let me know if you had come up with a better solution to
this part of custom resource execution

### Relates
- <URL or Ticket>

### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)?
  - Is the input sanitized?
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization?
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
  • Loading branch information
noah-paige authored Nov 11, 2024
1 parent a9471a3 commit 7213603
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deploy/stacks/cognito.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def __init__(
domain_prefix=f"{resource_prefix.replace('-', '')}{envname}{self.region.replace('-', '')}{self.account}"
),
)
id_token_duration = 120 if with_approval_tests else 60
id_token_duration = 180 if with_approval_tests else 60
self.client = cognito.UserPoolClient(
self,
f'AppClient-{envname}',
Expand Down

0 comments on commit 7213603

Please sign in to comment.