Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkov baseline #1019

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Add checkov baseline #1019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b628c43
Add Checkov Baseline and remove checkov skip exceptions
noah-paige Jan 29, 2024
8eb11f1
Edit Checkov GH Workflow to reference baseline
noah-paige Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 97 additions & 0 deletions .checkov.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
{
"failed_checks": [
{
"file": "/backend/docker/prod/ecs/Dockerfile",
"findings": [
{
"resource": "/backend/docker/prod/ecs/Dockerfile.",
"check_ids": [
"CKV_DOCKER_2"
]
},
{
"resource": "/backend/docker/prod/ecs/Dockerfile.ADD",
"check_ids": [
"CKV_DOCKER_4",
"CKV_DOCKER_4",
"CKV_DOCKER_4",
"CKV_DOCKER_4",
"CKV_DOCKER_4"
]
}
]
},
{
"file": "/backend/docker/prod/lambda/Dockerfile",
"findings": [
{
"resource": "/backend/docker/prod/lambda/Dockerfile.",
"check_ids": [
"CKV_DOCKER_2"
]
}
]
},
{
"file": "/deploy/cdk_exec_policy/cdkExecPolicy.yaml",
"findings": [
{
"resource": "AWS::IAM::ManagedPolicy.CDKCustomExecutionPolicy0",
"check_ids": [
"CKV_AWS_107",
"CKV_AWS_109",
"CKV_AWS_110",
"CKV_AWS_111"
]
}
]
},
{
"file": "/deploy/pivot_role/pivotRole.yaml",
"findings": [
{
"resource": "AWS::IAM::ManagedPolicy.PivotRolePolicy0",
"check_ids": [
"CKV_AWS_109",
"CKV_AWS_111"
]
},
{
"resource": "AWS::IAM::ManagedPolicy.PivotRolePolicy1",
"check_ids": [
"CKV_AWS_109",
"CKV_AWS_111"
]
},
{
"resource": "AWS::IAM::ManagedPolicy.PivotRolepolicy3",
"check_ids": [
"CKV_AWS_109"
]
}
]
},
{
"file": "/documentation/userguide/docker/prod/Dockerfile",
"findings": [
{
"resource": "/documentation/userguide/docker/prod/Dockerfile.",
"check_ids": [
"CKV_DOCKER_2"
]
}
]
},
{
"file": "/frontend/docker/prod/Dockerfile",
"findings": [
{
"resource": "/frontend/docker/prod/Dockerfile.",
"check_ids": [
"CKV_DOCKER_2"
]
}
]
}
]
}
2 changes: 1 addition & 1 deletion .github/workflows/checkov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
skip_path: tests/, .github, compose/, docker/dev/
hard_fail_on: MEDIUM
soft_fail_on: LOW
skip_check: CKV_DOCKER_2,CKV_DOCKER_4
baseline: .checkov.baseline
4 changes: 0 additions & 4 deletions deploy/cdk_exec_policy/cdkExecPolicy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ Parameters:
Resources:
CDKCustomExecutionPolicy0:
Type: 'AWS::IAM::ManagedPolicy'
# checkov:skip=CKV_AWS_107:Ensure IAM policies does not allow credentials exposure
# checkov:skip=CKV_AWS_109:Ensure IAM policies does not allow permissions management without constraints
# checkov:skip=CKV_AWS_110:Ensure IAM policies does not allow privilege escalation
# checkov:skip=CKV_AWS_111:Ensure IAM policies does not allow write access without constraints
Properties:
ManagedPolicyName: !Ref PolicyName
PolicyDocument:
Expand Down
5 changes: 0 additions & 5 deletions deploy/pivot_role/pivotRole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ Resources:
]
PivotRolePolicy0:
Type: 'AWS::IAM::ManagedPolicy'
# checkov:skip=CKV_AWS_109:Ensure IAM policies does not allow permissions management without constraints
# checkov:skip=CKV_AWS_111:Ensure IAM policies does not allow write access without constraints
Properties:
PolicyDocument:
Version: 2012-10-17
Expand Down Expand Up @@ -223,8 +221,6 @@ Resources:

PivotRolePolicy1:
Type: 'AWS::IAM::ManagedPolicy'
# checkov:skip=CKV_AWS_109:Ensure IAM policies does not allow permissions management without constraints
# checkov:skip=CKV_AWS_111:Ensure IAM policies does not allow write access without constraints
Properties:
PolicyDocument:
Version: 2012-10-17
Expand Down Expand Up @@ -425,7 +421,6 @@ Resources:

PivotRolepolicy3:
Type: 'AWS::IAM::ManagedPolicy'
# checkov:skip=CKV_AWS_109:Ensure IAM policies does not allow permissions management without constraints
Properties:
PolicyDocument:
Version: 2012-10-17
Expand Down
Loading