Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/vpc refactoring - Refactor vpc module to follow api/services/db layers #1044

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Feb 7, 2024

Feature or Bugfix

  • Refactoring

Detail

Some modules under core do not completely follow the standard structure agreed for modules. In this PR I just focus on the module vpc:

  • Add input validation in the api layer in the resolvers
  • Create a service layer for vpc, where we check permissions and execute business logic
  • The db subpackage should contain all operations on RDS. It should not contain business logic, permissions checks or input validation.

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx changed the title Refactor vpc module to follow api/services/db layers Core/vpc refactoring - Refactor vpc module to follow api/services/db layers Feb 8, 2024
@dlpzx
Copy link
Contributor Author

dlpzx commented Feb 8, 2024

Testing in AWS:

  • CICD pipeline succeeds
  • Create network in environment
  • List environment networks in Notebooks
  • Delete newly create network
  • Delete pre-existing network

@dlpzx dlpzx marked this pull request as ready for review February 8, 2024 08:58
Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dlpzx dlpzx merged commit e1e9e08 into main Feb 8, 2024
8 checks passed
@dlpzx dlpzx deleted the fix/clean_up_core branch February 12, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants