feat: custom env linking text

[zsaltys]

Feature or Bugfix

• Feature

Detail

• Adding a way to override env linking prerequisites for those that do not want to use manual steps and have other ways to achieve the same thing. You can see in this picture how we use it:

Security

The only security concern is that there's an html value coming out of config.json which gets set as innerHTML. I don't think this would be an issue unless someone would find a way to override the config. value as an attack.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[zsaltys]

@noah-paige @dlpzx please review.. btw I can't set you as reviewers :)

[dlpzx]

Hi @zsaltys, thanks for opening a PR :) We will review with @maryamkhidir and @itsmo-amzn after v2.1.0 is released

[zsaltys]

@dlpzx thanks!

[zsaltys]

@itsmo-amzn @maryamkhidir I will make a PR that uses DOMPurify and a new react component? Will that be acceptable to merge this in?

[maryamkhidir]

@zsaltys Yes, that works

[zsaltys]

@maryamkhidir @itsmo-amzn I have added support for DOMPurify. I have close to no experience with React or NPM so apologies if I've made some mistakes. Please let me know if there's anything else I should fix.

[noah-paige]

Changed the target branch to main - will need to pull latest from main to resolve above conflicts before merging this PR

[maryamkhidir]

@zsaltys Taking a look

[maryamkhidir]

Are you expecting a link from the config? If not, I don't think you should allow href. Otherwise, it looks good.

[zsaltys]

@maryamkhidir yes we are using links. That's the main reason I needed HTML support. We provide links for users to our internal systems so they know how to onboard data.all environments.

[dlpzx]

Thanks for picking it up @zsaltys, the PR also needs to be updates with the latest changes in main to avoid the conflicts before merge

[zsaltys]

Re-raised this PR to the main branch: https://github.com/awslabs/aws-dataall/pull/934/files .. To avoid solving a huge merge conflict by changing the base on this branch.