-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker user directives #895
Conversation
# Conflicts: # backend/docker/dev/Dockerfile # backend/docker/prod/ecs/Dockerfile # backend/docker/prod/lambda/Dockerfile
@dbalintx I have seen your deployment in AWS with the latest changes. I went ahead and tested some items there:
|
@dlpzx thank you for checking it @mourya-33 I think you need to provide permissions to |
@dbalintx I added permissions for tmp directory for all the docker files |
Tested the latest changes to this PR in an AWS internet facing deployment:
Getting the same errors as before with permission issues @mourya-33 |
@noah-paige i updated the permissions for temp dir and tested the dataset and environment creation as well. |
Hi @mourya-33 thanks for the changes, we are almost there!
I also tested locally:
|
@dlpzx is this ready to be merged or more testing is needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! Ready to be merged
Feature or Bugfix
Detail
This PR is to add USER directive to all the Docker files
Relates
#864
Security
Please answer the questions below briefly where applicable, or write
N/A
. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)? No
eval
or similar functions are used? N/ABy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.