FIX - Frontend Config Role Issue while switching from Cognito Idp to Custom Auth

[TejasRGitHub]

Feature or Bugfix

• Bugfix

Detail

Added Conditional statement on using appropriate role when setting data.all with custom auth versus cognito.

Relates

#937

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

• Does this PR introduce or modify any input fields or queries - this includes
  fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A
  • Is the input sanitized?
  • What precautions are you taking before deserializing the data you consume?
  • Is injection prevented by parametrizing queries?
  • Have you ensured no eval or similar functions are used?
• Does this PR introduce any functionality or component that requires authorization? N/A
  • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  • Are you logging failed auth attempts?
• Are you using or adding any cryptographic features? N/A
  • Do you use a standard proven implementations?
  • Are the used keys controlled by the customer? Where are they stored?
• Are you introducing any new policies/roles/users? N/A
  • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[noah-paige]

Testing the PR for both an Custom Auth and Cognito Deployment:

• CICD Pipeline Succeeds
• frontend config role created for Custom Auth
• cognito config role created for Cognito Auth
• Access data.all frontend post-update

I think we can optimize some of the logic between custom auth deployments and default cognito auth deployments as an enhancement since it is not super straightforward.

I would be inclined to do so at the same time or after we get user guide deployed with custom auth patterns so the resources defined for using different auth patterns are quite similar.

For now this PR looks good and I will approve as is, thanks!

[noah-paige]

tested and lgtm, approving