Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade axios package to resolve follow-redirect vulnerability #952

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

noah-paige
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Fix npm audit vulnerability on follow-redirects package

Relates

N/A

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A
    • Is the input sanitized? N/A
    • What precautions are you taking before deserializing the data you consume? N/A
    • Is injection prevented by parametrizing queries? N/A
    • Have you ensured no eval or similar functions are used? N/A
  • Does this PR introduce any functionality or component that requires authorization? N/A
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms? N/A
    • Are you logging failed auth attempts? N/A
  • Are you using or adding any cryptographic features? N/A
    • Do you use a standard proven implementations? N/A
    • Are the used keys controlled by the customer? Where are they stored? N/A
  • Are you introducing any new policies/roles/users? N/A
    • Have you used the least-privilege principle? How? N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@noah-paige noah-paige marked this pull request as ready for review January 9, 2024 16:05
@noah-paige noah-paige requested a review from dlpzx January 9, 2024 16:07
@dlpzx
Copy link
Contributor

dlpzx commented Jan 10, 2024

Thanks @noah-paige for the PR. I have tested it in AWS:

  • CICD pipeline completes successfully
  • testing fileUpload functionality where the package is used ---> uploaded successfully (the Dataset had been created for a couples of days)

[Edit]

  • testing fileUpload functionality where the package is used ---> fails for imported Datasets with CORS error (but this happens also in the current version without the update)

@noah-paige noah-paige merged commit d32bd49 into main Jan 10, 2024
8 checks passed
@dlpzx dlpzx deleted the upgrade-axios-npm-audit branch April 25, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants