Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix - 948 | Added else if condition to get tables into InSync state #980

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

TejasRGitHub
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Added else if condition for getting the glue tables which exist on the AWS account and also present in RDS dataset tables set the LastGlueTableStatus to InSync.

Testing

  1. Created a dataset with tables
  2. Marked the dataset tables LastGlueTableStatus to Deleted.
  3. Checked if the table are now NOT displayed.
  4. Deployed data.all with this fix
  5. Now the dataset tables are present on the UI.

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization? No
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features? No
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users? No
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I will test in AWS. Thanks @TejasRGitHub !!

@noah-paige
Copy link
Contributor

Tested in AWS:

  • CICD Pipeline Succeeds
  • Removed glue:... permissions for pivot role + Synchronize on UI --> Tables update with Deleted Status and no show on UI
  • Re-add glue:... permissions for pivot role + Synchronize on UI --> Tables update with InSync Status and show on UI

Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, approving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glue table not visible after upgrading to v2.2 with enable auto created pivot role
3 participants