Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-993] - Removing AWS Manged Lake Formation Service Linked Role from Pivot Role Nested Stack #999

Merged
merged 1 commit into from
Jan 25, 2024
Merged

[GH-993] - Removing AWS Manged Lake Formation Service Linked Role from Pivot Role Nested Stack #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions backend/dataall/core/environment/cdk/pivot_role_stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,6 @@ def __init__(self, scope: Construct, construct_id: str, config, **kwargs) -> Non
external_id=config['externalId'],
)

# Data.All IAM Lake Formation service role creation
self.lf_service_role = iam.CfnServiceLinkedRole(
self, 'LakeFormationSLR', aws_service_name='lakeformation.amazonaws.com'
)

def create_pivot_role(self, principal_id: str, external_id: str) -> iam.Role:
"""
Creates an IAM Role that will enable data.all to interact with this Data Account
Expand Down
Loading