Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: site polish #13

Merged
merged 9 commits into from
Jul 12, 2023
Merged

feat: site polish #13

merged 9 commits into from
Jul 12, 2023

Conversation

tikagan
Copy link
Collaborator

@tikagan tikagan commented Jul 12, 2023

  • put header and footer back on col-12 grid
  • reverse card sidebar title scroll direction
  • section about typography polish
  • css compilation issues: site nav font size, margin between hero and section projects
  • new images for article cards
  • constrain site title on xlarge bp and above

Doesn't include:

  • infinite marquee for card sidebar titles

AU-2747

@tikagan tikagan requested a review from orvn July 12, 2023 19:18
@tikagan tikagan self-assigned this Jul 12, 2023
Copy link
Member

@orvn orvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Two notes:

  • The starting point of the sidebar marquee text doesn't align with the bottom of the card
    • Not prioritizing this because it can get fixed in the background image marquee approach
  • The blog images will probably need to be changed again, but this is good for now

@orvn orvn merged commit 8da0481 into develop Jul 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants