Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: qa round 2 performance #21

Merged
merged 9 commits into from
Jul 18, 2023
Merged

feat: qa round 2 performance #21

merged 9 commits into from
Jul 18, 2023

Conversation

tikagan
Copy link
Collaborator

@tikagan tikagan commented Jul 17, 2023

  • all <img> elements lazy load by default
  • images that are part of card contents loaded as <img> elements, not background-image
  • card component generates alt text for images based on file name
  • image files renamed for alt text
  • open panda project card sidebar image replaced with correct high contrast image

Ticket AU-2753

@tikagan tikagan self-assigned this Jul 17, 2023
@tikagan tikagan requested a review from orvn July 18, 2023 16:14
@tikagan
Copy link
Collaborator Author

tikagan commented Jul 18, 2023

@tjsMck if you want to take a look that all the images are still loading correctly (I checked but it doesn't hurt to double check) that would be great. Let @orvn still merge this PR though because of the lazy image loading

Copy link
Member

@orvn orvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we can keep the lazy loading, although I don't love it, because when I scroll too fast it feels like the page takes a while to load/is still loading. This might be an issue with slower latency from Fleek though. So let's keep it and then discuss more lazy loading strategy in a dev standards at some point.

@orvn orvn merged commit cc1e57d into develop Jul 18, 2023
1 check passed
@orvn orvn deleted the feat-qa-round-2-performance branch July 18, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants