Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: content + style updates #26

Merged
merged 9 commits into from
Jul 21, 2023
Merged

feat: content + style updates #26

merged 9 commits into from
Jul 21, 2023

Conversation

tikagan
Copy link
Collaborator

@tikagan tikagan commented Jul 21, 2023

  • adds KWRAY and GALEN & their images to section-people
  • deck of cards scrolls in same direction as collaborators slider
  • remove top and bottom padding from card sidebars
  • add padding to card sidebar marquee text (better visual while animating)
  • add dashboard button to sp reputation wg card
  • update medium url for All articles button
  • logos in section-collaborators slider don't lazy load
  • update instances of data-programs.org to dataprograms.org

Ticket AU-2775

@tikagan tikagan requested a review from tjsMck July 21, 2023 15:44
@tikagan tikagan self-assigned this Jul 21, 2023
@tikagan tikagan changed the title feat: final final changes feat: content + style updates Jul 21, 2023
Copy link
Member

@orvn orvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all the new changes, looks great!

@tikagan only note is to avoid versioning and branching with terms like final. After all, there will be future versions and other requests. You can always re-use the same polish or QA branches as well, although the PR name should be unique. I tend to do with things like:

style: miscellaneous polish or even something super ambiguous like feat: various pre-ship changes is okay. Basically we want to make sure we're as detailed as possible within the context, and sometimes, especially toward the end, that can involve some benign ambiguity (but ideally no more than we absolutely need 🙃).

revisioning

@orvn orvn merged commit 1de4136 into develop Jul 21, 2023
2 checks passed
@orvn orvn deleted the feat-final-final-changes branch July 21, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants