Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable svgs on fonts #74

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fix: disable svgs on fonts #74

merged 1 commit into from
Feb 23, 2024

Conversation

orvn
Copy link
Member

@orvn orvn commented Feb 23, 2024

Tests a fix to the Safari issue where the SVGs for the SuisseIntl font family appear to be corrupted for an unknown reason.

The screenshot below is one of the issue (prior to the fixes in this PR)
scrn 2024-02-23 at 11 29 24 AM


🎟️ Ticket AU-3212

@orvn orvn assigned tikagan and unassigned orvn Feb 23, 2024
@tikagan tikagan mentioned this pull request Feb 23, 2024
1 task
Copy link
Contributor

@tjsMck tjsMck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orvn ltgm, tested on chrome and safari, both desktop and on my phone.

Copy link
Collaborator

@tikagan tikagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also looks good to me

for context: Safari doesn't support SVG font files as of 16.4 and the presence of them appears to be what was causing the text rendering bug

@tjsMck tjsMck merged commit a65554f into main Feb 23, 2024
3 checks passed
@tjsMck tjsMck deleted the fix-safari-svg-fonts branch February 23, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants