-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code improvements in Scala reference implementation #5
base: master
Are you sure you want to change the base?
Conversation
dbehrouz
commented
Aug 18, 2015
- Use of more compact code
- Use immutable objects in TF IDF computation
- Fixed a bug in TF-IDF where the supplied input to the program was being ignored and a static location was being used as input.
Thanks a lot for the pull request. But from my point of view, the changes look reasonable. |
Thanks @bderak for your pull request. I agree with the Scala immutable object changes and the bug fixing in TF-IDF. However, it was intended for the code to not be very compact in order to make novices familiar with the general Flink transformations. It's not very Scala-esk I agree :) |
Hi @bderak, thanks for the fixes! As @mxm said, we used |
great. |