Skip to content

Commit

Permalink
todo
Browse files Browse the repository at this point in the history
  • Loading branch information
shreyas-goenka committed Dec 2, 2024
1 parent 06af01c commit 4b484fd
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions libs/filer/dbfs_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,14 @@ func (w *DbfsClient) uploadUsingDbfsStreamingApi(ctx context.Context, path strin
return err
}

// TODO CONTINUE:
// 1. Write the unit tests that make sure the filer write method works correctly
// in either case.
// 2. Write a intergration test that asserts write continues works for big file
// uploads. Also test the overwrite flag in the integration test.
// We can change MaxDbfsUploadLimitForPutApi in the test to avoid creating
// massive test fixtures.

// MaxUploadLimitForPutApi is the maximum size in bytes of a file that can be uploaded
// using the /dbfs/put API. If the file is larger than this limit, the streaming
// API (/dbfs/create and /dbfs/add-block) will be used instead.
Expand Down

0 comments on commit 4b484fd

Please sign in to comment.