Skip to content

Commit

Permalink
fmt
Browse files Browse the repository at this point in the history
  • Loading branch information
shreyas-goenka committed Jan 17, 2025
1 parent 9649f23 commit 56e4d9f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 12 deletions.
2 changes: 1 addition & 1 deletion bundle/run/job_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ func TestJobRunnerRestartForContinuousUnpausedJobs(t *testing.T) {

m := mocks.NewMockWorkspaceClient(t)
b.SetWorkpaceClient(m.WorkspaceClient)

ctx := cmdio.MockDiscard(context.Background())
ctx = cmdio.NewContext(ctx, cmdio.NewLogger(flags.ModeAppend))

Expand Down
2 changes: 1 addition & 1 deletion bundle/run/pipeline_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func TestPipelineRunnerRestart(t *testing.T) {
Host: "https://test.com",
}
b.SetWorkpaceClient(m.WorkspaceClient)

ctx := cmdio.MockDiscard(context.Background())
ctx = cmdio.NewContext(ctx, cmdio.NewLogger(flags.ModeAppend))

Expand Down
13 changes: 4 additions & 9 deletions libs/template/template_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,13 @@ func TestTemplateTelemetryIsCapturedForAllDefaultTemplates(t *testing.T) {
for _, tmpl := range databricksTemplates {
w := tmpl.Writer

if tmpl.name == Custom {
// Assert telemetry is not captured for user templates.
assert.IsType(t, &defaultWriter{}, w)
} else {
// Assert telemetry is captured for all other templates, i.e. templates
// owned by databricks.
assert.IsType(t, &writerWithFullTelemetry{}, w)
}
// Assert telemetry is captured for all databricks templates, i.e. templates
// owned by databricks.
assert.IsType(t, &writerWithFullTelemetry{}, w)
}
}

func TestTemplateGet(t *testing.T) {
func TestTemplateGetDatabricksTemplate(t *testing.T) {
names := []TemplateName{
DefaultPython,
DefaultSql,
Expand Down
2 changes: 1 addition & 1 deletion libs/template/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,6 @@ type writerWithFullTelemetry struct {
}

func (tmpl *writerWithFullTelemetry) LogTelemetry(ctx context.Context) error {
// TODO, log template name, uuid and enum args as well.``
// TODO, log template name, uuid and enum args as well.
return nil
}

0 comments on commit 56e4d9f

Please sign in to comment.