Skip to content

Commit

Permalink
Add integration test for the /telemetry-ext endpoint (#2259)
Browse files Browse the repository at this point in the history
## Changes
Followup from
#2209 (review).

This PR adds an integration test to validate that the API type bindings
work against the telemetry endpoint.

## Tests
N/A

---------

Co-authored-by: Pieter Noordhuis <[email protected]>
  • Loading branch information
shreyas-goenka and pietern authored Jan 29, 2025
1 parent 13596eb commit c3a6e11
Showing 1 changed file with 65 additions and 0 deletions.
65 changes: 65 additions & 0 deletions integration/libs/telemetry/telemetry_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
package telemetry

import (
"encoding/json"
"testing"
"time"

"github.com/databricks/cli/integration/internal/acc"
"github.com/databricks/cli/libs/telemetry"
"github.com/databricks/cli/libs/telemetry/protos"
"github.com/databricks/databricks-sdk-go/client"
"github.com/google/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestTelemetryEndpoint(t *testing.T) {
ctx, wt := acc.WorkspaceTest(t)
w := wt.W

apiClient, err := client.New(w.Config)
require.NoError(t, err)

logs := []protos.FrontendLog{
{
FrontendLogEventID: uuid.New().String(),
Entry: protos.FrontendLogEntry{
DatabricksCliLog: protos.DatabricksCliLog{
CliTestEvent: &protos.CliTestEvent{Name: protos.DummyCliEnumValue1},
},
},
},
{
FrontendLogEventID: uuid.New().String(),
Entry: protos.FrontendLogEntry{
DatabricksCliLog: protos.DatabricksCliLog{
CliTestEvent: &protos.CliTestEvent{Name: protos.DummyCliEnumValue2},
},
},
},
}

protoLogs := make([]string, len(logs))
for i, log := range logs {
b, err := json.Marshal(log)
require.NoError(t, err)
protoLogs[i] = string(b)
}

reqB := telemetry.RequestBody{
UploadTime: time.Now().UnixMilli(),
Items: []string{},
ProtoLogs: protoLogs,
}

respB := telemetry.ResponseBody{}

err = apiClient.Do(ctx, "POST", "/telemetry-ext", nil, nil, reqB, &respB)
require.NoError(t, err)

assert.Equal(t, telemetry.ResponseBody{
Errors: []telemetry.LogError{},
NumProtoSuccess: int64(2),
}, respB)
}

0 comments on commit c3a6e11

Please sign in to comment.