Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased chan size for clusters test to pass #1691

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Increased chan size for clusters test to pass #1691

merged 1 commit into from
Aug 19, 2024

Conversation

andrewnester
Copy link
Contributor

Changes

Increased chan size for clusters test to pass

@andrewnester andrewnester enabled auto-merge August 19, 2024 09:56
shreyas-goenka
shreyas-goenka approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@shreyas-goenka shreyas-goenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify which test exactly requires increasing the buffer? Why does it emit so many logs?

@andrewnester andrewnester added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit f99335e Aug 19, 2024
5 checks passed
@andrewnester andrewnester deleted the fix/cluster-list-test-increase branch August 19, 2024 10:05
@andrewnester
Copy link
Contributor Author

@shreyas-goenka it's follow up on this #1686
Test is TestAccClustersList, apparently some environments have more than 10k clusters. In a new version of Go SDK there is a switch to a new clusters API which started to return more clusters then before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-goenka shreyas-goenka shreyas-goenka approved these changes

@pietern pietern Awaiting requested review from pietern pietern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewnester @shreyas-goenka