Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle summary to display URLs for deployed resources #1731

Merged
merged 23 commits into from
Oct 18, 2024

Conversation

lennartkats-db
Copy link
Contributor

@lennartkats-db lennartkats-db commented Aug 29, 2024

Changes

Adds a textual output to the databricks bundle summary command, which includes URLs of deployed resources.

Example usage:

$ databricks bundle summary
Name: my_pipeline
Target: dev
Workspace:
  Host: https://domain.databricks.com
  User: [email protected]
  Path: /Users/[email protected]/.bundle/my_pipeline/dev
Resources:
  Jobs:
    my_project_job:
      Name: [dev lennart] my_project_job
      URL:  https://domain.databricks.com/jobs/206899209187287?o=6051921418418893
  Pipelines:
    my_project_pipeline:
      Name: [dev lennart] my_project_pipeline
      URL:  https://domain.databricks.com/pipelines/3f849fd5-ba7d-47fa-a34c-c6bf034b4f58?o=6051921418418893

Notes:

  • The top headers of the output are the same as those from the existing bundle validate command
  • URLs are colored light blue in the output
  • For resources that haven't been deployed yet, we show (not deployed) in place of the URL

@lennartkats-db lennartkats-db marked this pull request as ready for review August 29, 2024 14:46
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. Didn't look at the changes to the render package yet, and want to take a closer look as they may impact the output of the validate command.

bundle/config/mutator/initialize_urls.go Outdated Show resolved Hide resolved
bundle/config/mutator/initialize_urls.go Outdated Show resolved Hide resolved
bundle/config/mutator/initialize_urls.go Outdated Show resolved Hide resolved
bundle/config/mutator/initialize_urls.go Show resolved Hide resolved
@lennartkats-db
Copy link
Contributor Author

@pietern could you take another look? I addressed your initial comments. I was hoping to do a major pass over this in the airplane today; I'd really like to get this change in.

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are conflicts on the rendering code, there are more conflicts incoming, and they need to be moved around anyway. I can take care of that. Can you look at the inline comment on the org ID test, then I can do the rest.

bundle/config/mutator/initialize_urls_test.go Outdated Show resolved Hide resolved
bundle/config/mutator/initialize_urls.go Show resolved Hide resolved
bundle/config/mutator/initialize_urls.go Outdated Show resolved Hide resolved
bundle/config/mutator/initialize_urls.go Show resolved Hide resolved
bundle/config/mutator/initialize_urls_test.go Show resolved Hide resolved
bundle/render/render_text_output.go Outdated Show resolved Hide resolved
bundle/render/render_text_output_test.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

@lennartkats-db lennartkats-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle/config/mutator/initialize_urls_test.go Outdated Show resolved Hide resolved
bundle/config/mutator/initialize_urls_test.go Show resolved Hide resolved
bundle/config/resources.go Outdated Show resolved Hide resolved
@pietern pietern changed the title Add a bundle summary command that includes URLs of everything that is deployed Add bundle summary to display URLs for deployed resources Oct 18, 2024
@lennartkats-db lennartkats-db added this pull request to the merge queue Oct 18, 2024
Merged via the queue into databricks:main with commit c5043c3 Oct 18, 2024
5 checks passed
@lennartkats-db lennartkats-db deleted the cp-summary-with-urls branch October 18, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants