-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert SDK version is consistent in the CLI generation process #1814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you figure out how we can not run this test by default?
Maybe with build tags or something.
@pietern I think we can skip a filter on this test for now. It's pretty fast, it ran 100 times in 3.7 seconds on my local machine. It's difficult to determine whether we are regenerating the CLI in the context of the CLI code itself. The build tags are only set in the release workflow. We'd probably need to create some sort of flag in the |
Changes
Followup from #1809 (comment). User will see the following error if the SDK version does not match during CLI code generation.
Tests
Manually asserted that:
v0.47.1-0.20241002195128-6cecc224cbf7