Allow overriding compute for non-development mode targets #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Nov 18, 2024
| } | ||
| if v := env.Get(ctx, "DATABRICKS_CLUSTER_ID"); v != "" { | ||
| b.Config.Bundle.ClusterId = v | ||
| } | ||
|
|
||
| if b.Config.Bundle.ClusterId == "" { | ||
| return nil | ||
| return diags | ||
| } | ||
|
|
||
| r := b.Config.Resources | ||
| for i := range r.Jobs { | ||
| overrideJobCompute(r.Jobs[i], b.Config.Bundle.ClusterId) |
There was a problem hiding this comment.
Unrelated note: this also overrides serverless notebook tasks (without environment_key).
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Dec 2, 2024
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/12243557365 |
pietern
reviewed
Dec 9, 2024
|
@lennartkats-db I triggered integration tests (see the comment, it doesn't auto-trigger from forks). But then I tried it out and found the issue above, so I disabled auto-merge. |
|
@denik FYI, no review needed. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
…1994) ## Changes We should show a warning when using a cluster override with 'mode: production'. Right now, we inadvertently show an error for this state. This is a followup based on #1899 (comment).
andrewnester
added a commit
that referenced
this pull request
Dec 18, 2024
Bundles: * Allow overriding compute for non-development mode targets ([#1899](#1899)). * Avoid panic if Config.Workspace.CurrentUser.User is not set ([#1993](#1993)). * Show an error when using a cluster override with 'mode: production' ([#1994](#1994)). Internal: API Changes: * Added `databricks account federation-policy` command group. * Added `databricks account service-principal-federation-policy` command group. * Added `databricks aibi-dashboard-embedding-access-policy delete` command. * Added `databricks aibi-dashboard-embedding-approved-domains delete` command. OpenAPI commit a6a317df8327c9b1e5cb59a03a42ffa2aabeef6d (2024-12-16) Dependency updates: * Upgrade TF provider to 1.62.0 ([#2030](#2030)). * Upgrade Go SDK to 0.54.0 ([#2029](#2029)). * Bump TF codegen dependencies to latest ([#1961](#1961)). * Bump golang.org/x/term from 0.26.0 to 0.27.0 ([#1983](#1983)). * Bump golang.org/x/sync from 0.9.0 to 0.10.0 ([#1984](#1984)). * Bump github.com/databricks/databricks-sdk-go from 0.52.0 to 0.53.0 ([#1985](#1985)). * Bump golang.org/x/crypto from 0.24.0 to 0.31.0 ([#2006](#2006)). * Bump golang.org/x/crypto from 0.30.0 to 0.31.0 in /bundle/internal/tf/codegen ([#2005](#2005)).
andrewnester
added a commit
that referenced
this pull request
Dec 18, 2024
Bundles: * Allow overriding compute for non-development mode targets ([#1899](#1899)). * Show an error when using a cluster override with 'mode: production' ([#1994](#1994)). API Changes: * Added `databricks account federation-policy` command group. * Added `databricks account service-principal-federation-policy` command group. * Added `databricks aibi-dashboard-embedding-access-policy delete` command. * Added `databricks aibi-dashboard-embedding-approved-domains delete` command. OpenAPI commit a6a317df8327c9b1e5cb59a03a42ffa2aabeef6d (2024-12-16) Dependency updates: * Upgrade TF provider to 1.62.0 ([#2030](#2030)). * Upgrade Go SDK to 0.54.0 ([#2029](#2029)). * Bump TF codegen dependencies to latest ([#1961](#1961)). * Bump golang.org/x/term from 0.26.0 to 0.27.0 ([#1983](#1983)). * Bump golang.org/x/sync from 0.9.0 to 0.10.0 ([#1984](#1984)). * Bump github.com/databricks/databricks-sdk-go from 0.52.0 to 0.53.0 ([#1985](#1985)). * Bump golang.org/x/crypto from 0.24.0 to 0.31.0 ([#2006](#2006)). * Bump golang.org/x/crypto from 0.30.0 to 0.31.0 in /bundle/internal/tf/codegen ([#2005](#2005)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow overriding compute for non-development targets. We previously had a restriction in place where
--cluster-idwas only allowed for targets that usemode: development. The intention was to prevent mistakes, but this was overly restrictive.Tests
Updated unit tests.