Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to testutil.GetEnvOrSkipTest(t, "CLOUD_ENV") #2014

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Dec 13, 2024

Changes

These calls are no longer necessary now that integration tests use a main function that performs this check. This change updates integration tests that call this function. Of those, the call sites that initialize a workspace client are updated to use acc.WorkspaceTest(t) to get one.

Tests

n/a

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 2014
  • Commit SHA: 52e80a2d1bc91622b1d0bbd62eaa6f102b530fee

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12318077787

Copy link
Contributor

@denik denik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup!

integration/bundle/init_test.go Show resolved Hide resolved
@pietern pietern enabled auto-merge December 13, 2024 16:06
@pietern pietern added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 3b00d78 Dec 13, 2024
11 checks passed
@pietern pietern deleted the remove-get-env-or-skip-test branch December 13, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants