Require authentication when a user runs bundle init
#2040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
commented
Dec 20, 2024
| @@ -152,20 +138,13 @@ func loadHelpers(ctx context.Context) template.FuncMap { | |||
| } | |||
| return *cachedCatalog, nil | |||
| }, | |||
| "is_service_principal": func() (bool, error) { | |||
| "is_service_principal": func() bool { | |||
There was a problem hiding this comment.
Go text templates use the error returned in the second value as purely a signal to terminate materializing the template. The second value is not something that a user template can access and, thus, should be safe to remove from the type signature here.
There was a problem hiding this comment.
shreyas-goenka
changed the title
bundle init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This will allow us to collect authenticated telemetry on
bundle initTests
Manually.
Existing templates like default-python are successfully created.
When invalid credentials are present, bundle init exists early (before prompting):