Enable offline install of labs projects #2049
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HariGS-DB
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
reviewed
Jan 20, 2025
HariGS-DB
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
pietern
changed the title
pietern
reviewed
Jan 29, 2025
| @@ -9,7 +9,7 @@ | |||
| ], | |||
| "go.useLanguageServer": true, | |||
| "gopls": { | |||
| "formatting.gofumpt": true | |||
| "formatting.gofumpt": true | |||
| @@ -15,15 +15,15 @@ import ( | |||
| ) | |||
|
|
|||
| type installable interface { | |||
| Install(ctx context.Context) error | |||
| Install(ctx context.Context, offlineInstall bool) error | |||
There was a problem hiding this comment.
This should be a property on the installable, not a function argument.
| } | ||
|
|
||
| type devInstallation struct { | ||
| *Project | ||
| *cobra.Command | ||
| } | ||
|
|
||
| func (d *devInstallation) Install(ctx context.Context) error { | ||
| func (d *devInstallation) Install(ctx context.Context, offlineInstall bool) error { |
There was a problem hiding this comment.
For example, not needed here.
| @@ -54,7 +54,7 @@ func (d *devInstallation) Install(ctx context.Context) error { | |||
| return d.Installer.runHook(d.Command) | |||
| } | |||
|
|
|||
| func NewInstaller(cmd *cobra.Command, name string) (installable, error) { | |||
| func NewInstaller(cmd *cobra.Command, name string, offlineInstall bool) (installable, error) { | |||
There was a problem hiding this comment.
The bool should be a property on the installer struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR makes changes to labs code base to allow for offline install of labs project (like UCX). by passing a flag --offline-install=true, the code will skip checking for project versions, and downloading code from github and instead will look from local installation folder. It is expected that the user will download and copy the code from other machine where it can install labs project and then run installation on the machine which has internet restriction.
Closes #1646
related to databrickslabs/ucx#3418
Tests
Added unit test case and tested.