Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert some resolve variables tests to acceptance test #2100

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Convert some resolve variables tests to acceptance test #2100

merged 3 commits into from
Jan 8, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 8, 2025

No description provided.

@denik denik temporarily deployed to test-trigger-is January 8, 2025 16:23 — with GitHub Actions Inactive
@denik denik enabled auto-merge January 8, 2025 16:26
@denik denik changed the title Convert TestResolveComplexVariableReferencesToFields to acceptance test Convert some resolve variables tests to acceptance test Jan 8, 2025
@denik denik temporarily deployed to test-trigger-is January 8, 2025 16:37 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 8, 2025 16:41 — with GitHub Actions Inactive
pietern
pietern approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

The only downside is you can no longer step through if something doesn't work as expected. I'd love to figure out a way to do that with the CLI binary being executed from within the acceptance test (e.g. some hook to launch a debugger for the process).

@denik denik added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit df17e4b Jan 8, 2025
9 checks passed
@denik denik deleted the denik/tests-complex branch January 8, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denik @pietern