Add Verbose option on testcli.Runner #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
pietern,
andrewnester and
shreyas-goenka
as code owners
pietern
reviewed
Jan 20, 2025
internal/testcli/runner.go
Outdated
| @@ -39,6 +39,8 @@ type Runner struct { | |||
| StderrLines <-chan string | |||
|
|
|||
| errch <-chan error | |||
|
|
|||
| NoLog bool | |||
There was a problem hiding this comment.
Can you flip this around and name it "LogOutput"? It can initialize to true from NewRunner.
It avoids the double negation in conditionals.
There was a problem hiding this comment.
Good idea, changed to Verbose.
pietern
approved these changes
Jan 20, 2025
denik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Setting Verbose=false on testcli.Runner disables all logging related to running process (stdout, stderr, error, args).
I'm using this in #2184 where I'm using testcli runner to run acceptance tests and seeing all output is not useful.
Tests
Manually inspecting test output in #2184