Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for #2181 /Workspace not prepended #2188

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Add test for #2181 /Workspace not prepended #2188

merged 3 commits into from
Jan 21, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 20, 2025

No description provided.

@denik denik temporarily deployed to test-trigger-is January 20, 2025 09:32 — with GitHub Actions Inactive
@denik denik changed the title Add regression test for #2181 Add test for #2181 Jan 20, 2025
@denik denik changed the title Add test for #2181 Add test for #2181 /Workspace not prepended Jan 20, 2025
@denik denik enabled auto-merge January 20, 2025 16:12
@pietern pietern disabled auto-merge January 20, 2025 16:31
pietern
pietern approved these changes Jan 20, 2025
View reviewed changes
acceptance/bundle/variables/prepend-workspace-var/script
@@ -0,0 +1,2 @@
echo /Workspace should be prepended on all paths, but it is not the case:
$CLI bundle validate -o json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a link to this PR and #2181 as well. Need git log otherwise to figure out where this comes from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added link to #2181.

@denik denik temporarily deployed to test-trigger-is January 21, 2025 10:40 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 21, 2025 10:46 — with GitHub Actions Inactive
@denik denik added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 33613b5 Jan 21, 2025
9 checks passed
@denik denik deleted the denik/test-workspace-prepend branch January 21, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewnester andrewnester andrewnester approved these changes

@pietern pietern pietern approved these changes

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denik @pietern @andrewnester