Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BuildCLI function to testutil package #2211

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Jan 22, 2025

Changes

This function is in general useful for black box testing. Thus this PR moves it to testutil.

I plan to use it in my upcoming PR for a process based telemetry logger: #2212

Tests

Existing tests pass.

@denik
Copy link
Contributor

denik commented Jan 23, 2025

I think it would be better to keep binary compilation a one-time thing we do in acceptance tests.

It's not great because it is slow, breaks dependency tracking, debugging and coverage (we need to account or work around for all of that in acceptance tests).

Let's discuss how we can structure your tests to use a combination of acceptance tests and regular unit tests.

Copy link
Contributor

@denik denik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants