Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go SDK to 0.56.0 #2214

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Upgrade Go SDK to 0.56.0 #2214

merged 2 commits into from
Jan 23, 2025

Conversation

andrewnester
Copy link
Contributor

Changes

Upgrade Go SDK to 0.56.0

Relevant changes:

@@ -109,16 +109,19 @@ var {{.CamelName}}Overrides []func(
{{- end }}
)

{{- $excludeFromJson := list "http-request"}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround to avoid conflicting flags coming from "serving-endpoints.http-request" and global json we provide. We need to find a better way to deal with it. cc @pietern @denik

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- this seems like a call we would need to special-case anyway.

@andrewnester andrewnester added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 798189e Jan 23, 2025
9 checks passed
@andrewnester andrewnester deleted the upgrade-go-sdk-0.56.0 branch January 23, 2025 11:24
andrewnester added a commit that referenced this pull request Jan 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants