Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test-specific logic from generic test runner #2215

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Remove test-specific logic from generic test runner #2215

merged 1 commit into from
Jan 23, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 23, 2025 •
edited
Loading

Revert changes to acceptance_test.go added in #2177 and add test-specific fix.

@denik denik temporarily deployed to test-trigger-is January 23, 2025 10:53 — with GitHub Actions Inactive
@denik denik mentioned this pull request Jan 23, 2025
Merged
@denik
Copy link
Contributor Author

denik commented Jan 23, 2025

cc @kanterov

@denik denik enabled auto-merge January 23, 2025 10:57
@denik denik disabled auto-merge January 23, 2025 10:58
@denik denik merged commit ba3a400 into main Jan 23, 2025
8 of 9 checks passed
@denik denik deleted the denik/cleanup-acceptance-test branch January 23, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denik @pietern