-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libs/python: Remove DetectInterpreters #2234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved and updated. The changes include: 1. Removing the import of `github.com/databricks/cli/libs/python` from `cmd/labs/project/installer.go` 2. Creating new files in `cmd/labs/project/`: - `interpreters.go` - `interpreters_unix_test.go` - `interpreters_win_test.go` The code has been moved from `libs/python/` to `cmd/labs/project/` with the same functionality. Would you like me to help you with anything else related to this refactoring?
andrewnester
approved these changes
Jan 27, 2025
andrewnester
added a commit
that referenced
this pull request
Jan 29, 2025
Bundles: * Added support for double underscore variable references ([#2203](#2203)). * Do not wait for app compute to start on `bundle deploy` ([#2144](#2144)). * Remove bundle.git.inferred ([#2258](#2258)). * libs/python: Remove DetectInterpreters ([#2234](#2234)). API Changes: * Added `databricks access-control` command group. * Added `databricks serving-endpoints http-request` command. * Changed `databricks serving-endpoints create` command with new required argument order. * Changed `databricks serving-endpoints get-open-api` command return type to become non-empty. * Changed `databricks recipients update` command return type to become non-empty. OpenAPI commit 0be1b914249781b5e903b7676fd02255755bc851 (2025-01-22) Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.55.0 to 0.56.1 ([#2238](#2238)). * Upgrade TF provider to 1.64.1 ([#2247](#2247)).
andrewnester
added a commit
that referenced
this pull request
Jan 29, 2025
Bundles: * Added support for double underscore variable references ([#2203](#2203)). * Do not wait for app compute to start on `bundle deploy` ([#2144](#2144)). * Remove bundle.git.inferred ([#2258](#2258)). * libs/python: Remove DetectInterpreters ([#2234](#2234)). API Changes: * Added `databricks access-control` command group. * Added `databricks serving-endpoints http-request` command. * Changed `databricks serving-endpoints create` command with new required argument order. * Changed `databricks serving-endpoints get-open-api` command return type to become non-empty. * Changed `databricks recipients update` command return type to become non-empty. OpenAPI commit 0be1b914249781b5e903b7676fd02255755bc851 (2025-01-22) Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.55.0 to 0.56.1 ([#2238](#2238)). * Upgrade TF provider to 1.64.1 ([#2247](#2247)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a follow up to #2034
Tests
Existing tests.