Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs/python: Remove DetectInterpreters #2234

Merged
merged 7 commits into from
Jan 27, 2025
Merged

libs/python: Remove DetectInterpreters #2234

merged 7 commits into from
Jan 27, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 27, 2025

Changes

  • Remove DetectInterpreters from DetectExecutable call: python3 or python should always be on on the PATH. We don't need to detect non-standard situations like python3.10 is present but python3 is not.
  • I moved DetectInterpreters to cmd/labs where it is still used.

This is a follow up to #2034

Tests

Existing tests.

denik added 7 commits January 27, 2025 11:44
…ved and updated. The changes include:

1. Removing the import of `github.com/databricks/cli/libs/python` from `cmd/labs/project/installer.go`
2. Creating new files in `cmd/labs/project/`:
   - `interpreters.go`
   - `interpreters_unix_test.go`
   - `interpreters_win_test.go`

The code has been moved from `libs/python/` to `cmd/labs/project/` with the same functionality.

Would you like me to help you with anything else related to this refactoring?
@denik denik temporarily deployed to test-trigger-is January 27, 2025 11:30 — with GitHub Actions Inactive
@denik denik changed the title Simplify libs/python: Remove DetectInterpreters from DetectExecutable libs/python: Remove DetectInterpreters from DetectExecutable Jan 27, 2025
@denik denik changed the title libs/python: Remove DetectInterpreters from DetectExecutable libs/python: Remove DetectInterpreters Jan 27, 2025
@denik denik added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 65fbbd9 Jan 27, 2025
9 checks passed
@denik denik deleted the denik/refactor-python branch January 27, 2025 13:29
andrewnester added a commit that referenced this pull request Jan 29, 2025
Bundles:
 * Added support for double underscore variable references ([#2203](#2203)).
 * Do not wait for app compute to start on `bundle deploy` ([#2144](#2144)).
 * Remove bundle.git.inferred ([#2258](#2258)).
 * libs/python: Remove DetectInterpreters ([#2234](#2234)).

API Changes:
 * Added `databricks access-control` command group.
 * Added `databricks serving-endpoints http-request` command.
 * Changed `databricks serving-endpoints create` command with new required argument order.
 * Changed `databricks serving-endpoints get-open-api` command return type to become non-empty.
 * Changed `databricks recipients update` command return type to become non-empty.

OpenAPI commit 0be1b914249781b5e903b7676fd02255755bc851 (2025-01-22)
Dependency updates:
 * Bump github.com/databricks/databricks-sdk-go from 0.55.0 to 0.56.1 ([#2238](#2238)).
 * Upgrade TF provider to 1.64.1 ([#2247](#2247)).
andrewnester added a commit that referenced this pull request Jan 29, 2025
Bundles:
* Added support for double underscore variable references
([#2203](#2203)).
* Do not wait for app compute to start on `bundle deploy`
([#2144](#2144)).
* Remove bundle.git.inferred
([#2258](#2258)).
* libs/python: Remove DetectInterpreters
([#2234](#2234)).

API Changes:
 * Added `databricks access-control` command group.
 * Added `databricks serving-endpoints http-request` command.
* Changed `databricks serving-endpoints create` command with new
required argument order.
* Changed `databricks serving-endpoints get-open-api` command return
type to become non-empty.
* Changed `databricks recipients update` command return type to become
non-empty.

OpenAPI commit 0be1b914249781b5e903b7676fd02255755bc851 (2025-01-22)
Dependency updates:
* Bump github.com/databricks/databricks-sdk-go from 0.55.0 to 0.56.1
([#2238](#2238)).
* Upgrade TF provider to 1.64.1
([#2247](#2247)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants