Always close test HTTP server during cleanup #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
requested review from
pietern,
andrewnester and
denik
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
requested changes
Jan 29, 2025
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Jan 29, 2025
acceptance/acceptance_test.go
Outdated
| @@ -109,6 +109,8 @@ func testAccept(t *testing.T, InprocessMode bool, singleTest string) int { | |||
|
|
|||
| if cloudEnv == "" { | |||
| server := testserver.New(t) | |||
| t.Cleanup(server.Close) | |||
There was a problem hiding this comment.
Can we call Close from testserver.New() instead? Then it is impossible to use wrong.
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
changed the title
pietern
approved these changes
Jan 29, 2025
denik
approved these changes
Jan 29, 2025
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR registers the
server.Close()function to be run during test cleanup in the server initialization function. This ensures that all test servers are closed as soon as the test they are scoped to finish.Motivated by https://github.com/databricks/cli/pull/2255/files where a regression was introduced where we did not close the test server.
Tests
N/A