-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request body assertions to acceptance tests #2263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
requested review from
pietern,
andrewnester and
denik
as code owners
January 29, 2025 14:45
shreyas-goenka
temporarily deployed
to
test-trigger-is
January 29, 2025 14:45 — with
GitHub Actions
Inactive
shreyas-goenka
force-pushed
the
validate-request-body
branch
from
January 30, 2025 10:44
59f28d6
to
8b568b4
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
January 30, 2025 10:44 — with
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
January 31, 2025 01:02 — with
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
January 31, 2025 01:07 — with
GitHub Actions
Inactive
denik
reviewed
Jan 31, 2025
shreyas-goenka
temporarily deployed
to
test-trigger-is
January 31, 2025 10:41 — with
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
January 31, 2025 10:44 — with
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
January 31, 2025 10:45 — with
GitHub Actions
Inactive
denik
reviewed
Jan 31, 2025
shreyas-goenka
temporarily deployed
to
test-trigger-is
January 31, 2025 11:27 — with
GitHub Actions
Inactive
denik
approved these changes
Jan 31, 2025
shreyas-goenka
temporarily deployed
to
test-trigger-is
January 31, 2025 13:08 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, any acceptance tests that define custom server stubs in
test.toml
will automatically record all HTTP requests made and assert on them.Builds on top of #2226
Tests
Modifying existing acceptance test.