-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accept JSON includes #2265
base: main
Are you sure you want to change the base?
accept JSON includes #2265
Conversation
databricks#2201 disabled using JSON as part of a bundle definition. I believe this was not intended.
@spoltier could you please share what's your use case for including JSONs? |
We have JSON job definitions originally copied and lightly adapted JSONs from the jobs UI, which works just as well as YAML to define resources. Since the validation is about preventing arbitrary file includes, I assumed it was an oversight. |
We expected that some users might use JSON for defining configuration but since YAML is also available from UI we did not expect it to be very common. There is no plan to drop JSON support for config, so we will bring it back, thanks for reporting! As to PR itself, to accept the changes it requires new contributors to sign CLA, if that's something you're willing to do, feel free to reach out to [email protected] and we will take it from there. |
Thanks! I've sent an email. |
diags = diags.Append(diag.Diagnostic{ | ||
Severity: diag.Error, | ||
Summary: "Files in the 'include' configuration section must be YAML files.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to change an output for the tests here to make sure it matches: https://github.com/databricks/cli/blob/main/acceptance/bundle/includes/non_yaml_in_include/output.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, changed the output
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
#2201 disabled using JSON as part of a bundle definition. I believe this was not intended.
Changes
Accept json files as includes, just as YAML files.
Tests
Covered by the tests in #2201