acc: Added acceptance test for CLI commands inside bundle with and without profile flag #2270
Conversation
andrewnester
requested review from
pietern,
shreyas-goenka and
denik
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
force-pushed
the
acc/cli-bundle-auth
branch
from
5e950bb to
eb81b33
Compare
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| @@ -0,0 +1 @@ | |||
| Badness = "When -p flag is used inside the bundle folder for any CLI commands, CLI use bundle host anyway instead of profile one" | |||
There was a problem hiding this comment.
How do I know from the output which host is used? The commands only output the user.
There was a problem hiding this comment.
Using correct host meaning current-user me returns a expected user. There are no CLI commands (API) which returns host being used, so we can't really use server stubs unless we deviate from API responses.
We could use describe auth describe command to see the host but this would deviate a bit from idea of this test: "I want my autogenerated CLI commands to make calls against correct host depending on flags I pass"
There was a problem hiding this comment.
One idea on testing different hosts that comes to mind (up to you if you think it's worth it):
- Set up 2 servers in the test runner, $DATABRICKS_HOST and $DATABRICKS_OTHER_HOST
- Update RequestLog added by @shreyas-goenka feature to include host that is being used.
| targets: | ||
| dev: | ||
| default: true | ||
| workspace: |
There was a problem hiding this comment.
nit: We don't have to override the same host here since it's the default target
There was a problem hiding this comment.
Indeed, but I just made it explicit
| "$USERNAME" | ||
|
|
||
| === Inside the bundle, target and matching profile | ||
| >>> errcode $CLI current-user me -t dev -p DEFAULT |
There was a problem hiding this comment.
nit: This doesn't provide any extra coverage since -t dev is implicit in the configuration. Same below.
There was a problem hiding this comment.
It does, because it test what happens if we provide both -t and -p with matching hosts.
because we could make a change making -t and -p exclusive and this test would break
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…thout profile flag
andrewnester
force-pushed
the
acc/cli-bundle-auth
branch
from
2ea42d7 to
66ff914
Compare
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Changes
This encodes existing behaviour in CLI as reported here: #1358