[PECO-909] Automatically renew oauth token when refresh token is available #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create client if needed) Signed-off-by: Levko Kravets <[email protected]>
Signed-off-by: Levko Kravets <[email protected]>
Signed-off-by: Levko Kravets <[email protected]>
…w on every request Signed-off-by: Levko Kravets <[email protected]>
Signed-off-by: Levko Kravets <[email protected]>
kravets-levko
changed the title
Signed-off-by: Levko Kravets <[email protected]>
kravets-levko
requested review from
arikfr,
superdupershant,
yunbodeng-db,
susodapop,
nithinkdb and
andrefurlan-db
as code owners
nithinkdb
approved these changes
Jul 29, 2023
nithinkdb
pushed a commit
to nithinkdb/databricks-sql-nodejs
that referenced
this pull request
Aug 21, 2023
…lable (databricks#156) * HiveDriver: obtain a thrift client before each request (allows to re-create client if needed) Signed-off-by: Levko Kravets <[email protected]> * Move auth logic to DBSQLClient Signed-off-by: Levko Kravets <[email protected]> * Remove redundant HttpTransport class Signed-off-by: Levko Kravets <[email protected]> * Cache OAuth tokens in memory by default to avoid re-running OAuth flow on every request Signed-off-by: Levko Kravets <[email protected]> * Re-create thrift client when auth credentials (e.g. oauth token) change Signed-off-by: Levko Kravets <[email protected]> * Update tests Signed-off-by: Levko Kravets <[email protected]> --------- Signed-off-by: Levko Kravets <[email protected]> Signed-off-by: nithinkdb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PECO-909
It is possible to auto-renew oauth access token if corresponding refresh token was provided. However, due to some limitations in library architecture, it wasn't possible to use that mechanism: after
DBSQLClient.connect()call credentials were cached and not updated until re-connected. In this PR the following changes are suggestsed:HiveDrivershould not cache thrift client object and obtain it before running each operation. This allows to provide a new client if needed;thriftlibrary does not provide any API to just update client options,DBSQLClientwill re-create thrift client (and connection) when needed. Turns out that this is safe and almost does not add much overhead (especially considering that token refresh does not happen very often).HttpConnectionand moved toDBSQLClientsoDBSQLClientcan detect credentials changeHiveDriverneeds a client instance,DBSQLClientwill request auth credentials, and if they have changed (e.g. oauth access token expired and was refreshed) - it will create a new thrift client.DatabricksOAuthstores token on its own. The existing persistence mechanism was utilized for this purpose.This is quite a big change, but library's public interface and observed behavior won't change.
Probably review will be easier commit by commit.