Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PECO-964] Initial Staging Ingestion implementation #159

Closed
wants to merge 3 commits into from
Closed

[PECO-964] Initial Staging Ingestion implementation #159

wants to merge 3 commits into from

Conversation

nithinkdb
Copy link
Contributor

@nithinkdb nithinkdb commented Aug 16, 2023 •
edited by jira bot
Loading

kravets-levko
kravets-levko reviewed Aug 16, 2023
View reviewed changes
lib/DBSQLSession.ts Outdated Show resolved Hide resolved
kravets-levko
kravets-levko reviewed Aug 17, 2023
View reviewed changes
lib/DBSQLSession.ts Outdated Show resolved Hide resolved
@kravets-levko kravets-levko changed the title Peco 984 [PECO-964] Initial Staging Ingestion implementation Aug 17, 2023
kravets-levko
kravets-levko approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@kravets-levko kravets-levko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Checked unit and e2e tests - both passed for me locally

@nithinkdb nithinkdb force-pushed the PECO-984 branch 2 times, most recently from 0d8d22c to e06060e Compare August 21, 2023 19:27
@kravets-levko kravets-levko self-requested a review August 21, 2023 19:41
@kravets-levko
Copy link
Contributor

This PR was accidentally screwed up. Replaced with #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr Awaiting requested review from arikfr

@superdupershant superdupershant Awaiting requested review from superdupershant superdupershant is a code owner

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db yunbodeng-db is a code owner

@susodapop susodapop Awaiting requested review from susodapop

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

@kravets-levko kravets-levko Awaiting requested review from kravets-levko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nithinkdb @kravets-levko