Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PECO-930] Add parameterized query support. #162

Merged
merged 11 commits into from
Sep 6, 2023

Conversation

nithinkdb
Copy link
Contributor

@nithinkdb nithinkdb commented Aug 17, 2023

Closes #96

lib/DBSQLClient.ts Outdated Show resolved Hide resolved
lib/utils/ParameterConverter.ts Outdated Show resolved Hide resolved
lib/contracts/IDBSQLSession.ts Outdated Show resolved Hide resolved
Copy link

@andrefurlan-db andrefurlan-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure that we keep it consistent with Go and Python. @rcypher-databricks needs to review this as well

Copy link

@rcypher-databricks rcypher-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed I think we need to provide a mechanism where the user can specify the desired sql type.

lib/utils/convertToSparkParameters.ts Outdated Show resolved Hide resolved
@nithinkdb nithinkdb merged commit ad10743 into databricks:main Sep 6, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterized queries
4 participants