Fix: proxy agent unintentionally overwrites protocol in URL #241
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Levko Kravets <[email protected]>
kravets-levko
requested review from
arikfr,
superdupershant,
yunbodeng-db,
andrefurlan-db,
rcypher-databricks,
jackyhu-db and
benc-db
as code owners
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
- Coverage 93.24% 93.24% -0.01%
==========================================
Files 63 63
Lines 1525 1524 -1
Branches 266 266
==========================================
- Hits 1422 1421 -1
Misses 41 41
Partials 62 62 ☔ View full report in Codecov by Sentry. |
benc-db
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237
A proxy agent was configured to use a protocol of proxy itself as a protocol for proxy target. In some cases this causes an unintentional modification of target URLs - see #237 (comment)
I don't actually remember why I used that option, maybe I didn't fully understood its impact.