Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore #255

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Chore #255

merged 6 commits into from
Apr 29, 2024

Conversation

kravets-levko
Copy link
Contributor

@kravets-levko kravets-levko commented Apr 23, 2024

Each commit is a separate change:

  • Get rid of redundant lib/hive/Types - some types there were just re-exports, some were used in the only place, some were unused at all. The only type that was used more than once was replaced by a function
  • Allow any number type (number, bigint, Int64) for maxRows and queryTimeout (related to Documentation on timeout options needs clarification #167)
  • Move some global constants to client config
  • Add a note about queryTimeout option (also related to Documentation on timeout options needs clarification #167)
  • Use a dedicated AuthenticationError class instead of a generic Error for errors in auth-related code

@databricks databricks deleted a comment from codecov-commenter Apr 23, 2024
@kravets-levko kravets-levko changed the title Chore Chore (WIP) Apr 23, 2024
@kravets-levko kravets-levko changed the title Chore (WIP) Chore Apr 23, 2024
@databricks databricks deleted a comment from codecov-commenter Apr 23, 2024
@kravets-levko kravets-levko merged commit c239fca into main Apr 29, 2024
8 checks passed
@kravets-levko kravets-levko deleted the chores-2024-04-23 branch April 29, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants