Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues with exporting. #1160

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Fix some issues with exporting. #1160

merged 4 commits into from
Feb 2, 2024

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Feb 2, 2024

  • Fix issue where jsonl=True throws an error, and add unit tests.
  • Fix issue where we can't export signals from the UI.

https://huggingface.co/spaces/lilacai/nikhil_staging

signal_export.mov

@nsthorat nsthorat requested review from dsmilkov and brilee February 2, 2024 16:28
@nsthorat nsthorat merged commit 72e123d into main Feb 2, 2024
4 checks passed
@nsthorat nsthorat deleted the nik-sig-export branch February 2, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brilee brilee brilee approved these changes

@dsmilkov dsmilkov Awaiting requested review from dsmilkov

Assignees
No one assigned
Labels
backend client lib frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsthorat @brilee