Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search by display_name to databricks_service_principal data source #2963

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Nov 28, 2023

Changes

Allow searching not only by application_id, but also by the exact display_name.

This fixes #2959

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team as code owners November 28, 2023 07:03
@alexott alexott requested review from tanmay-db and removed request for a team November 28, 2023 07:03
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Merging #2963 (1f59d59) into master (52af61d) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2963   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files         153      154    +1     
  Lines       13634    13665   +31     
=======================================
+ Hits        11454    11481   +27     
- Misses       1533     1536    +3     
- Partials      647      648    +1     
Files Coverage Δ
scim/data_service_principal.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

scim/data_service_principal.go Show resolved Hide resolved
… source

Allow to search not only by `application_id`, but also by the exact `display_name`.

This fixes #2959
@alexott alexott added this pull request to the merge queue Jan 9, 2024
Merged via the queue into master with commit 030d446 Jan 9, 2024
5 checks passed
@alexott alexott deleted the issue-2959 branch January 9, 2024 12:36
@tanmay-db tanmay-db mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for searching by service principal name in databricks_service_principal data source
4 participants