Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add a note about workspace or account-level provider usage #3074

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jan 5, 2024

Changes

Explicitly say at what level (account, workspace, or both) the specific resource could be used.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

Explicitly say at what level (account, workspace, or both) the specific resource could be used.
@alexott alexott requested review from a team as code owners January 5, 2024 09:09
@alexott alexott requested review from tanmay-db and removed request for a team January 5, 2024 09:09
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a7ff2f) 84.55% compared to head (2c74e3c) 84.55%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3074   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files         161      161           
  Lines       14187    14187           
=======================================
  Hits        11996    11996           
  Misses       1508     1508           
  Partials      683      683           

docs/resources/system_schema.md Outdated Show resolved Hide resolved
docs/resources/registered_model.md Outdated Show resolved Hide resolved
docs/resources/catalog_workspace_binding.md Outdated Show resolved Hide resolved
docs/resources/metastore_assignment.md Outdated Show resolved Hide resolved
@alexott alexott requested a review from nkvuong January 5, 2024 09:51
@alexott
Copy link
Contributor Author

alexott commented Jan 5, 2024

Thank you @nkvuong - somehow I mixed up some copy-pastes...

@alexott alexott added this pull request to the merge queue Jan 5, 2024
Merged via the queue into master with commit 44eefaa Jan 5, 2024
5 checks passed
@alexott alexott deleted the doc-specify-provider-level branch January 5, 2024 10:22
@tanmay-db tanmay-db mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants