Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter: add support for databricks_artifact_allowlist #3083

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jan 7, 2024

Changes

Also refactored a bit to avoid duplicate calls to metastore summary API

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

Also refactored a bit to avoid duplicate calls to metastore summary API
@alexott alexott requested review from a team as code owners January 7, 2024 10:08
@alexott alexott requested review from mgyucht and removed request for a team January 7, 2024 10:08
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2fe11af) 84.59% compared to head (4e6c9d5) 84.59%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3083      +/-   ##
==========================================
- Coverage   84.59%   84.59%   -0.01%     
==========================================
  Files         161      161              
  Lines       14214    14230      +16     
==========================================
+ Hits        12025    12038      +13     
- Misses       1507     1508       +1     
- Partials      682      684       +2     
Files Coverage Δ
exporter/importables.go 80.47% <100.00%> (+0.16%) ⬆️
exporter/context.go 79.93% <40.00%> (-0.34%) ⬇️

@alexott alexott added the exporter TF configuration generator label Jan 7, 2024
@mgyucht mgyucht added this pull request to the merge queue Jan 8, 2024
Merged via the queue into master with commit ebfc026 Jan 8, 2024
5 checks passed
@mgyucht mgyucht deleted the exporter-uc-artifact-allowlist branch January 8, 2024 16:24
@tanmay-db tanmay-db mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter TF configuration generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants